]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
checkpatch: There is no qemu_strtod()
authorEric Blake <eblake@redhat.com>
Fri, 10 Jun 2016 02:48:07 +0000 (20:48 -0600)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 30 Jun 2016 13:24:36 +0000 (15:24 +0200)
Maybe there should be; but until there is, we should not flag
strtod() calls as something to replaced with qemu_strtod().

We also lack qemu_strtof() and qemu_strtold(), but as no one
has been using strtof() or strtold(), it's not worth complicating
the regex for them.

(Ironically, I had to use 'git commit -n' since checkpatch uses
TAB indents, in violation of its own recommendations.)

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
scripts/checkpatch.pl

index c939a325bca965b3ce74bdce213def7e08715ea2..cf32c8f5fa32ada7c64f066908c6db368dc9e656 100755 (executable)
@@ -2453,7 +2453,7 @@ sub process {
                }
 
 # recommend qemu_strto* over strto* for numeric conversions
-               if ($line =~ /\b(strto[^k].*?)\s*\(/) {
+               if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
                        WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
                }
 # check for module_init(), use category-specific init macros explicitly please