]> xenbits.xensource.com Git - libvirt.git/commitdiff
virt-aa-helper-test: only fails go to stdout by default
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Thu, 26 Oct 2017 13:22:11 +0000 (15:22 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 27 Oct 2017 08:32:02 +0000 (10:32 +0200)
By Default (without -d) the tests will only print Failures.
So a log should follow general "no message is a good message" style.

But the testfw checks always emit the skip info to stdout. Instead
they should use the redirection that is controlled by -d.

This avoids mesages like the following to clutter the log:
  Skipping FW AAVMF32 test. Could not find /usr/share/AAVMF/AAVMF32_CODE.fd

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
tests/virt-aa-helper-test

index e8376687e71bb8b34e87f56a6167796a773fd41a..d2a557e3600f9b0876837dee79f3971fbb2bcf8c 100755 (executable)
@@ -155,7 +155,7 @@ testfw() {
             -e "s,</os>,<loader readonly='yes' type='pflash'>$fwpath</loader></os>,g" "$template_xml" > "$test_xml"
         testme "0" "$title" "-r -u $valid_uuid" "$test_xml"
     else
-        echo "Skipping FW $title test. Could not find $fwpath"
+        echo "Skipping FW $title test. Could not find $fwpath" >$output
     fi
 }