]> xenbits.xensource.com Git - qemu-xen-4.0-testing.git/commitdiff
Nicer fix for spurious messages from configure when GCC3 is missing.
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 22 Jul 2008 15:28:06 +0000 (16:28 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Thu, 28 Aug 2008 17:01:06 +0000 (18:01 +0100)
This reverts b5123e05cce4be4c6c8c822fad0f0df4c053da06 and replaces it
with a nice simple change, namely to change  test ... -a ...  with
test ... && test ... .  That provides shortcut evaluation.

Thanks to Andre Przywara who provided this one-line change as an
update to the previous commit.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
configure

index 5d1825f4e19ba3add3f2471a04c0ef5adc10b9b6..f138bec28871acebb6d534e7f5b54989e17c38aa 100755 (executable)
--- a/configure
+++ b/configure
@@ -1204,16 +1204,11 @@ case "$target_cpu" in
     fi
     echo "#define CONFIG_DYNGEN_OP 1" >> $config_h
     gcc3minver=`$cc --version 2> /dev/null| fgrep "(GCC) 3." | awk '{ print $3 }' | cut -f2 -d.`
-    if test -n "$gcc3minver"
+    if test -n "$gcc3minver" && test $gcc3minver -gt 3
     then
-      if test -a $gcc3minver -gt 3;
-      then
-        echo "HAVE_GT_GCC_3_3=true" >> $config_mak
-      else
-        echo "HAVE_GT_GCC_3_3=false" >> $config_mak
-      fi
-    else
       echo "HAVE_GT_GCC_3_3=true" >> $config_mak
+    else
+      echo "HAVE_GT_GCC_3_3=false" >> $config_mak
     fi
   ;;
   x86_64)