]> xenbits.xensource.com Git - xen.git/commitdiff
blktap2: initialise buf in vhd_util_check_footer
authorWei Liu <wei.liu2@citrix.com>
Fri, 29 Apr 2016 15:11:15 +0000 (16:11 +0100)
committerWei Liu <wei.liu2@citrix.com>
Fri, 6 May 2016 14:50:23 +0000 (15:50 +0100)
Gcc complains:

vhd-util-check.c: In function ‘vhd_util_check_footer’:
vhd-util-check.c:413:2: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  memcpy(&backup, buf, sizeof(backup));

In fact buf is initialised a few lines above.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
tools/blktap2/vhd/lib/vhd-util-check.c

index af07426d5b637d63345a9c1e1ed2a86172b78e5c..40565ac2336e63c0272482c8619a1c1f4ade3823 100644 (file)
@@ -335,7 +335,7 @@ vhd_util_check_footer(int fd, vhd_footer_t *footer, int ignore)
 {
        size_t size;
        int err, opened;
-       char *msg, *buf;
+       char *msg, *buf = NULL;
        off_t eof, off;
        vhd_footer_t primary, backup;