]> xenbits.xensource.com Git - staging/qemu-xen-4.1-testing.git/commit
pcnet: force the buffer access to be in bounds during tx master
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (10:53 +0200)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Tue, 23 Jun 2015 10:44:30 +0000 (11:44 +0100)
commit77d9bdb27c4237a007ba93a6f159791eed317abc
treeb2c61b7c1173b1c8b8f93043508fd088ded2b1a1
parentbbf2cd02b3d199ae16608fc3fcf53543b4771a10
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/pcnet.c