]> xenbits.xensource.com Git - qemu-upstream-4.2-testing.git/commit
xenfb: avoid reading twice the same fields from the shared page master
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 15:45:14 +0000 (15:45 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 18 Dec 2015 16:00:38 +0000 (16:00 +0000)
commit5081fc1c773d2a83ec7a867f030323b8b6956cd1
tree1118e3e9f597684f147145da0b2f99da5802cdf9
parent74fab2ef4c0ba42af477e9e445c9883cc45cf9e6
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xenfb.c