]> xenbits.xensource.com Git - libvirt.git/commit
net/qemu: move vlan/bandwidth validation out of network driver osstest/frozen/xen-4.13-testing
authorLaine Stump <laine@redhat.com>
Tue, 1 Oct 2019 18:05:58 +0000 (14:05 -0400)
committerLaine Stump <laine@redhat.com>
Mon, 25 Nov 2019 20:30:10 +0000 (15:30 -0500)
commit9d6920bd7de3f92be1894790adeb689060ab25eb
treee6a1aea4ceb2d38e60daa6658bd710c5024f8d62
parentb03d9e95932e978f0857582b1e5efc73f13132c1
net/qemu: move vlan/bandwidth validation out of network driver

In the past the network driver was (mistakenly) being called for all
interfaces, not just those of type='network', and so it had a chance
to validate all interface configs after the actual type of the
interface was known.

But since the network driver has been more completely/properly
separated from qemu, the network driver isn't called during the
startup of any interfaces except those with type='network', so this
validation no longer takes place for, e.g. <interface type='bridge'>
(or direct, etc). This in turn meant that a config could erroneously
specify a vlan tag, or bandwidth settings, for a type of interface
that didn't support it, and the domain would start without complaint,
just silently ignoring those settings.

This patch moves those validation checks out of the network driver,
and into virDomainActualNetDefValidate() so they will be done for all
interfaces, not just type='network'.

https://bugzilla.redhat.com/1741121
Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
src/conf/domain_conf.c
src/network/bridge_driver.c