]> xenbits.xensource.com Git - libvirt.git/commit
tests: xmconfigtest: add tests for cmdline formating osstest/frozen/xen-4.10-testing osstest/frozen/xen-4.11-testing osstest/frozen/xen-4.9-testing
authorJim Fehlig <jfehlig@suse.com>
Wed, 23 May 2018 21:09:45 +0000 (15:09 -0600)
committerJim Fehlig <jfehlig@suse.com>
Tue, 5 Jun 2018 02:59:16 +0000 (20:59 -0600)
commit076a2b409667dd9f716a2a2085e1ffea9d58fe8b
tree6af5595b2498c07d0547b806aa4117e1421f4d00
parent67c56f6e65b9cd2681ef1bc61d8b51cbc543fa42
tests: xmconfigtest: add tests for cmdline formating

Commit 656151bf fixed formatting of the <cmdline> element. Perhaps it
would have been noticed and fixed earlier if we had a test. With this
change, all possible cases of formatting <cmdline> from xmconfig are
covered

1. no 'extra=' or 'root=' in xm.cfg
2. 'extra=' but no 'root=' in xm.cfg
3. 'root=' but no 'extra=' in xm.cfg
4. both 'root=' and 'extra=' in xm.cfg

Case 1 is covered by all existing paravirt tests since they have no
'extra=' or 'root='. Case 2 is covered by adding 'extra=' to a few
of the existing paravirt tests. Cases 3 and 4 are covered by new
tests that only test conversion of xm.cfg to xml.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
tests/xmconfigdata/test-paravirt-extra-root.cfg [new file with mode: 0644]
tests/xmconfigdata/test-paravirt-extra-root.xml [new file with mode: 0644]
tests/xmconfigdata/test-paravirt-maxvcpus.cfg
tests/xmconfigdata/test-paravirt-maxvcpus.xml
tests/xmconfigdata/test-paravirt-root.cfg [new file with mode: 0644]
tests/xmconfigdata/test-paravirt-root.xml [new file with mode: 0644]
tests/xmconfigdata/test-paravirt-vcpu.cfg
tests/xmconfigdata/test-paravirt-vcpu.xml
tests/xmconfigtest.c