]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commit
xen/disk: don't leak stack data via response ring master
authorJan Beulich <jbeulich@suse.com>
Wed, 21 Jun 2017 15:44:17 +0000 (16:44 +0100)
committerAnthony PERARD <anthony.perard@citrix.com>
Wed, 21 Jun 2017 15:44:17 +0000 (16:44 +0100)
commit853d4dbe41ab40dfd289b93158afbb41ddcb4a54
treeec969576af8d487feba4b13bcf0e919cd65b0125
parent6b0966a4422a6374db0f250b181bb4276c9e7a10
xen/disk: don't leak stack data via response ring

Rather than constructing a local structure instance on the stack, fill
the fields directly on the shared ring, just like other (Linux)
backends do. Build on the fact that all response structure flavors are
actually identical (the old code did make this assumption too).

This is XSA-216.

Reported-by: Anthony Perard <anthony.perard@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
hw/block/xen_blkif.h
hw/block/xen_disk.c