]> xenbits.xensource.com Git - libvirt.git/commit
util: fix removal of callbacks in virCloseCallbacksRun
authorMichael Chapman <mike@very.puzzling.org>
Wed, 8 Apr 2015 03:22:39 +0000 (13:22 +1000)
committerJán Tomko <jtomko@redhat.com>
Wed, 8 Apr 2015 07:45:48 +0000 (09:45 +0200)
commitfa2607d57713f4234ff75777468f43d9f5ec67a2
tree44615463e932c347d1d3ccaa4b91b9f51084d723
parente5d729ba42d86eb3afa9799bca2944700fde41bb
util: fix removal of callbacks in virCloseCallbacksRun

The close callbacks hash are keyed by a UUID-string, but
virCloseCallbacksRun was attempting to remove them by raw UUID. This
patch ensures the callback entries are removed by UUID-string as well.

This bug caused problems when guest migrations were abnormally aborted:

  # timeout --signal KILL 1 \
      virsh migrate example qemu+tls://remote/system \
        --verbose --compressed --live --auto-converge \
        --abort-on-error --unsafe --persistent \
        --undefinesource --copy-storage-all --xml example.xml
  Killed

  # virsh migrate example qemu+tls://remote/system \
      --verbose --compressed --live --auto-converge \
      --abort-on-error --unsafe --persistent \
      --undefinesource --copy-storage-all --xml example.xml
  error: Requested operation is not valid: domain 'example' is not being migrated

Signed-off-by: Michael Chapman <mike@very.puzzling.org>
src/util/virclosecallbacks.c