]> xenbits.xensource.com Git - xen.git/commit
x86/PV: drop dead paging_update_paging_modes() call during Dom0 construction
authorJan Beulich <jbeulich@suse.com>
Thu, 22 Dec 2022 09:06:57 +0000 (10:06 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 22 Dec 2022 09:06:57 +0000 (10:06 +0100)
commitf90a265f5b6a10f558294e4d33642868fdabc416
treebcb4ff2e8569ab9c5f889d10a636010a62b0ddb1
parent5d58062192dc38daeb993589fe0d3c035ef6f9e6
x86/PV: drop dead paging_update_paging_modes() call during Dom0 construction

The function won't ever be invoked, as paging_mode_enabled() always
returns false here due to the immediately preceding clearing of
d->arch.paging.mode. While compilers recognize this and eliminate the
call, make this explicit in the source (which likely 9a28170f2da2 ["pvh
dom0: construct_dom0 changes"] should have done right away, albeit even
before that the call looks to have been pointless - shadow mode enabling
has occurred later virtually forever).

While there also update an adjacent partly stale comment.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/pv/dom0_build.c