]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commit
fdc: force the fifo access to be in bounds of the allocated buffer qemu-xen-4.5.1-rc2
authorPetr Matousek <pmatouse@redhat.com>
Wed, 6 May 2015 07:48:59 +0000 (09:48 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 13 May 2015 14:25:00 +0000 (14:25 +0000)
commitf582d00cf2055511153a87cc3c52565a0d1ae571
treedf66b3a075c47b9cd6ca5b7c13ef598622011494
parentc9ac5f816bf3a8b56f836b078711dcef6e5c90b8
fdc: force the fifo access to be in bounds of the allocated buffer

During processing of certain commands such as FD_CMD_READ_ID and
FD_CMD_DRIVE_SPECIFICATION_COMMAND the fifo memory access could
get out of bounds leading to memory corruption with values coming
from the guest.

Fix this by making sure that the index is always bounded by the
allocated memory.

This is CVE-2015-3456.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
hw/block/fdc.c