]> xenbits.xensource.com Git - governance.git/commit
Add Code Review Guide
authorLars Kurth <lars.kurth@citrix.com>
Mon, 30 Dec 2019 19:08:18 +0000 (19:08 +0000)
committerLars Kurth <lars.kurth@citrix.com>
Thu, 16 Jan 2020 15:08:52 +0000 (15:08 +0000)
commitf53b66040be5500c258dc1ef02e6247b2f0712f0
tree137dcd6b6f9e0f0296a152fa9ddf3746cc173607
parente2ebacd20a0e33967ccf02918505c8a8cedc95ab
Add Code Review Guide

This document highlights what reviewers such as maintainers and committers look
for when reviewing code. It sets expectations for code authors and provides
a framework for code reviewers.

Changes since v4
* Changed to comply with US English

Changes since v3
* Added example under *Workflow from a Reviewer's Perspective* section
* Fixed typos in text introduced in v2

Changes since v2 (introduced in v2)
* Extend introduction
* Add "Code Review Workflow" covering
  - "Workflow from a Reviewer's Perspective"
  - "Workflow from an Author's Perspective"
  - "Problematic Patch Reviews"
* Wrap to 80 characters
* Replace inline links with reference links to make
  wrapping easier

Signed-off-by: Lars Kurth <lars.kurth@citrix.com>
---
Cc: minios-devel@lists.xenproject.org
Cc: xen-api@lists.xenproject.org
Cc: win-pv-devel@lists.xenproject.org
Cc: mirageos-devel@lists.xenproject.org
Cc: committers@xenproject.org
code-review-guide.md [new file with mode: 0644]