]> xenbits.xensource.com Git - qemu-upstream-4.5-testing.git/commit
projects / qemu-upstream-4.5-testing.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 99aa8a7) | patch
cirrus: fix blit region check
authorGerd Hoffmann <kraxel@redhat.com>
Wed, 19 Nov 2014 10:37:42 +0000 (11:37 +0100)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 12:24:34 +0000 (12:24 +0000)
commitf49151814120538bac6c6f12109968544027cc20
tree08ac6a423e4875f7bf4dacceecd11c48f9f4ef6btree
parent99aa8a7e0a05cec2eb7562ab7107b27c6b042b08commit | diff
cirrus: fix blit region check

Issues:
 * Doesn't check pitches correctly in case it is negative.
 * Doesn't check width at all.

Turn macro into functions while being at it, also factor out the check
for one region which we then can simply call twice for src + dst.

This is CVE-2014-8106.

Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
hw/display/cirrus_vga.c diff | blob | history
Obsolete Upstream Qemu based repository for xen-4.5-testing