]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
xen: Disable use of O_DIRECT by default as it results in crashes.
authorAlex Bligh <alex@alex.org.uk>
Mon, 11 Mar 2013 14:02:49 +0000 (14:02 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Thu, 14 Mar 2013 19:28:53 +0000 (19:28 +0000)
commitf3903bbac78a81fcbce1350cdce860764a62783a
tree44236e8a6ee02b4bace64e447df09096745f3f7e
parente6e112f5f1b8a9dde8dd037d6a48f621d8a6ca01
xen: Disable use of O_DIRECT by default as it results in crashes.

Due to what is almost certainly a kernel bug, writes with O_DIRECT may
continue to reference the page after the write has been marked as
completed, particularly in the case of TCP retransmit. In other
scenarios, this "merely" risks data corruption on the write, but with
Xen pages from domU are only transiently mapped into dom0's memory,
resulting in kernel panics when they are subsequently accessed.

This brings PV devices in line with emulated devices.  Removing
O_DIRECT is safe as barrier operations are now correctly passed
through.

See:
  http://lists.xen.org/archives/html/xen-devel/2012-12/msg01154.html
for more details.

Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen_disk.c