]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commit
slirp: udp: fix NULL pointer dereference because of uninitialized socket
authorPetr Matousek <pmatouse@redhat.com>
Thu, 18 Sep 2014 06:35:37 +0000 (08:35 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Thu, 5 Mar 2015 14:53:22 +0000 (14:53 +0000)
commitf08788407a555564a9310a01cd10066bae2c4734
tree2dc9891963efd6c62a9393da788195366d3000f6
parent2b4231f563d9fe03fd937adae061e7508b9728c7
slirp: udp: fix NULL pointer dereference because of uninitialized socket

When guest sends udp packet with source port and source addr 0,
uninitialized socket is picked up when looking for matching and already
created udp sockets, and later passed to sosendto() where NULL pointer
dereference is hit during so->slirp->vnetwork_mask.s_addr access.

Fix this by checking that the socket is not just a socket stub.

This is CVE-2014-3640.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Xavier Mehrenberger <xavier.mehrenberger@airbus.com>
Reported-by: Stephane Duverger <stephane.duverger@eads.net>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-id: 20140918063537.GX9321@dhcp-25-225.brq.redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
slirp/udp.c