]> xenbits.xensource.com Git - libvirt.git/commit
tests: Fix virQEMUDriverConfigNew() calling with respect to @root
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 23 Mar 2020 08:55:54 +0000 (09:55 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 7 Apr 2020 13:26:10 +0000 (15:26 +0200)
commitf00f4ea7b17d7d1a0db58bf8ca4de1f4ce1ca256
tree71f28e9f0e04920833287f25601f718565a94d7b
parentf3d1582e3c0cff978d6af26100e3fc0221b3005e
tests: Fix virQEMUDriverConfigNew() calling with respect to @root

The virQEMUDriverConfigNew() accepts path to root directory for
embed mode as an argument. If the argument is not NULL it uses
the passed value as prefix for some internal paths (e.g.
cfg->libDir). If it is NULL though, it looks if the other
argument, @privileged is true or false and generates internal
paths accordingly. But when calling the function from the test
suite, instead of passing NULL for @root, an empty string is
passed. Fortunately, this doesn't create a problem because in
both problematic cases the generated paths are "fixed" to point
somewhere into build dir or the code which is tested doesn't
access them.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
tests/domaincapstest.c
tests/testutilsqemu.c