]> xenbits.xensource.com Git - qemu-upstream-4.3-testing.git/commit
pcnet: force the buffer access to be in bounds during tx
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (10:53 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 10 Jun 2015 11:49:19 +0000 (11:49 +0000)
commitefae5e0f79f77c77720185a0d8a49f3ba49071e7
treeb0a8eb389e272f085693f5a7f49c7df5b9eb71a2
parentf18719374c4242823ef0bc04fbd94840d62466e9
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/pcnet.c