]> xenbits.xensource.com Git - libvirt.git/commit
Revert "network: support setting firewalld zone for bridge device of open networks"
authorLaine Stump <laine@redhat.com>
Fri, 4 Oct 2024 17:46:20 +0000 (13:46 -0400)
committerLaine Stump <laine@redhat.com>
Wed, 9 Oct 2024 19:54:08 +0000 (15:54 -0400)
commitef760a413361a8992a3e56884a1ec09290954c71
treea240d8ceaaac132879fecca55b25599ff992a911
parent816876f51740da8b73c2176de3a64646772218f3
Revert "network: support setting firewalld zone for bridge device of open networks"

This reverts commit 1a72b83d566df952033529001b0f88a66d7f4393. That
patch had made the incorrect assumption that the firewalld zone of a
bridge would not be changed/removed when firewalld reloaded its rules
(e.g. with "killall -HUP firewalld"). It turns out my memory was
faulty, and this *does* remove the bridge interface's zone, which
results in guest networking failure after a firewalld reload, until
the virtual network is restarted.

The functionality reverted as a result of this patch reversion will be
added back in an upcoming patch that keeps the zone setting in
networkAddFirewallRules() (rather than moving it into a separate
function) so that it is called every time the network's firewall rules
are reloaded (including the reload that happens in response to a
reload notification from firewalld).

Signed-off-by: Laine Stump
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/network/bridge_driver.c
src/network/bridge_driver_linux.c
src/network/bridge_driver_nop.c
src/network/bridge_driver_platform.h