]> xenbits.xensource.com Git - people/aperard/linux.git/commit
netfilter: nf_tables: disallow element removal on anonymous sets
authorPablo Neira Ayuso <pablo@netfilter.org>
Sun, 10 Sep 2023 17:04:45 +0000 (19:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Oct 2023 19:46:36 +0000 (21:46 +0200)
commiteec981349b033a5a65b01cbc3cc039caa0790f8c
tree0cd630773ba04a58f6550394a0436ac160a72a31
parentd2a6844be5bd367444b3ec35ff8c565f7473e54f
netfilter: nf_tables: disallow element removal on anonymous sets

[ Upstream commit 23a3bfd4ba7acd36abf52b78605f61b21bdac216 ]

Anonymous sets need to be populated once at creation and then they are
bound to rule since 938154b93be8 ("netfilter: nf_tables: reject unbound
anonymous set before commit phase"), otherwise transaction reports
EINVAL.

Userspace does not need to delete elements of anonymous sets that are
not yet bound, reject this with EOPNOTSUPP.

From flush command path, skip anonymous sets, they are expected to be
bound already. Otherwise, EINVAL is hit at the end of this transaction
for unbound sets.

Fixes: 96518518cc41 ("netfilter: add nftables")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_tables_api.c