]> xenbits.xensource.com Git - libvirt.git/commit
Separate virGetHostname() API contract from driver APIs
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 26 Apr 2013 16:39:11 +0000 (17:39 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Wed, 8 May 2013 09:47:47 +0000 (10:47 +0100)
commitead630319d4141e93f96058d5f9a8bdf6dac2f53
tree1e2ebdc87ebdba44175db8e2924390027f148e89
parent979e9c56a7aadf2dcfbddd1abfbad594b78b4468
Separate virGetHostname() API contract from driver APIs

Currently the virGetHostname() API has a bogus virConnectPtr
parameter. This is because virtualization drivers directly
reference this API in their virDriverPtr tables, tieing its
API design to the public virConnectGetHostname API design.

This also causes problems for access control checks since
these must only be done for invocations from the public
API, not internal invocation.

Remove the bogus virConnectPtr parameter, and make each
hypervisor driver provide a dedicated function for the
driver API impl. This will allow access control checks
to be easily inserted later.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
15 files changed:
daemon/libvirtd-config.c
src/check-driverimpls.pl
src/libxl/libxl_driver.c
src/lxc/lxc_driver.c
src/openvz/openvz_driver.c
src/parallels/parallels_driver.c
src/qemu/qemu_driver.c
src/qemu/qemu_migration.c
src/test/test_driver.c
src/uml/uml_driver.c
src/util/virutil.c
src/util/virutil.h
src/vbox/vbox_tmpl.c
src/xen/xen_driver.c
src/xen/xend_internal.c