]> xenbits.xensource.com Git - libvirt.git/commit
tests: Add more tests for firmware selection
authorAndrea Bolognani <abologna@redhat.com>
Fri, 26 May 2023 16:19:24 +0000 (18:19 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 21 Aug 2023 11:51:23 +0000 (13:51 +0200)
commite930f62a02fbfa6eb710c79d148eb5d72bbce6eb
tree0504c1701e3dff76f95afa3f7502de08a4db7584
parent87d91e9e242520048579009ce2ddf8b238ec2733
tests: Add more tests for firmware selection

Most of these are just additional coverage, but a few demonstrate
bugs in libvirt:

  * firmware-manual-efi-nvram-template-nonstandard sees the NVRAM
    template path, which was explicitly provided in the XML,
    being overridden by the firmware selection machinery;

  * firmware-auto-efi-rw* and firmware-manual-efi-rw-legacy-paths
    lose the loader.readonly=no setting and thus behave
    differently than requested;

  * firmware-manual-efi-loader-path-nonstandard fails because an
    NVRAM path doesn't get generated.

We're going to address all these issues with upcoming changes.

Note that the firmware-auto-efi-nvram-template-nonstandard
failure is expected: firmware autoselection has been enabled, but
the NVRAM template points to a custom path that's not mentioned
in any of the firmware descriptors and so it can't succeed.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
47 files changed:
tests/qemuxml2argvdata/firmware-auto-efi-abi-update.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-abi-update.xml [new symlink]
tests/qemuxml2argvdata/firmware-auto-efi-format-loader-raw-abi-update.aarch64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-format-loader-raw-abi-update.xml [new symlink]
tests/qemuxml2argvdata/firmware-auto-efi-loader-secure-abi-update.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-loader-secure-abi-update.xml [new symlink]
tests/qemuxml2argvdata/firmware-auto-efi-nvram-template-nonstandard.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-nvram-template-nonstandard.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-nvram-template.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-nvram-template.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-rw-abi-update.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-rw-abi-update.xml [new symlink]
tests/qemuxml2argvdata/firmware-auto-efi-rw.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-auto-efi-rw.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-aarch64-legacy-paths.aarch64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-aarch64-legacy-paths.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-loader-path-nonstandard.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-loader-path-nonstandard.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-no-enrolled-keys-legacy-paths.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-no-enrolled-keys-legacy-paths.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-no-secboot-legacy-paths.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-no-secboot-legacy-paths.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-nonstandard.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-nvram-template-nonstandard.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-rw-legacy-paths.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-rw-legacy-paths.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-rw-modern-paths.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-rw-modern-paths.xml [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-secboot-legacy-paths.x86_64-latest.args [new file with mode: 0644]
tests/qemuxml2argvdata/firmware-manual-efi-secboot-legacy-paths.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c
tests/qemuxml2xmloutdata/firmware-auto-efi-abi-update.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-format-loader-raw-abi-update.aarch64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-loader-secure-abi-update.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram-template-nonstandard.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-nvram-template.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-rw-abi-update.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-auto-efi-rw.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-aarch64-legacy-paths.aarch64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-loader-path-nonstandard.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-no-enrolled-keys-legacy-paths.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-no-secboot-legacy-paths.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-nvram-template-nonstandard.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-rw-legacy-paths.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-rw-modern-paths.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmloutdata/firmware-manual-efi-secboot-legacy-paths.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxml2xmltest.c