]> xenbits.xensource.com Git - xen.git/commit
ACPI/ERST: fix signed/unsigned type conflicts
authorJan Beulich <jbeulich@suse.com>
Tue, 22 Apr 2014 10:05:44 +0000 (12:05 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 22 Apr 2014 10:05:44 +0000 (12:05 +0200)
commite681c0408564a2c0d1c6d56d3f683f8db079458c
treed40c93dfbf7267bd4cbb41fabc48125465ee4a8c
parent061eebe0e99ad45c9c3b1a778b06140de4a91f25
ACPI/ERST: fix signed/unsigned type conflicts

Error checks exist in the respective code path that expect negative
values to indicate errors, yet negative values can't be communicated
through size_t. Thus ssize_t needs to be introduced (also on ARM for
consistency, even if the code in question isn't currently being used
on there).

The bug is theoretical only in so far as all the involved code is
effectively dead. Reflect this by excluding that code from non-debug
builds.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Christoph Egger <chegger@amazon.de>
xen/arch/x86/cpu/mcheck/mce-apei.c
xen/common/lib.c
xen/drivers/acpi/apei/erst.c
xen/include/acpi/apei.h
xen/include/asm-arm/types.h
xen/include/asm-x86/types.h