]> xenbits.xensource.com Git - qemu-upstream-unstable.git/commit
scsi: fix buffer overflow in scsi_req_parse_cdb (CVE-2015-5158)
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 21 Jul 2015 06:59:39 +0000 (08:59 +0200)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 29 Jul 2015 15:20:24 +0000 (15:20 +0000)
commite40ae8730e83e25f160c7576dd32d882bf2a3846
tree073b76e68256039eddf5df1fe694343f5334cbcb
parent9ad5c2cf05a084ef2fab2b21c4175f0a34482664
scsi: fix buffer overflow in scsi_req_parse_cdb (CVE-2015-5158)

This is a guest-triggerable buffer overflow present in QEMU 2.2.0
and newer.  scsi_cdb_length returns -1 as an error value, but the
caller does not check it.

Luckily, the massive overflow means that QEMU will just SIGSEGV,
making the impact much smaller.

upstream-commit-id: c170aad8b057223b1139d72e5ce7acceafab4fa9

Reported-by: Zhu Donghai (朱东海) <donghai.zdh@alibaba-inc.com>
Fixes: 1894df02811f6b79ea3ffbf1084599d96f316173
Reviewed-by: Fam Zheng <famz@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/scsi/scsi-bus.c