]> xenbits.xensource.com Git - libvirt.git/commit
xenconfig: fix conversion of <driver> to backendtype
authorJim Fehlig <jfehlig@suse.com>
Thu, 16 Jun 2016 05:09:36 +0000 (23:09 -0600)
committerJim Fehlig <jfehlig@suse.com>
Thu, 16 Jun 2016 18:31:04 +0000 (12:31 -0600)
commite33cd67a9b51e8fcb4e084f40f500057b30b2786
treee8b51e16d5432a5ae01351bed738d19f4668eb07
parentbf913385ae0a3671cb729010a1aa4ec3e700d7bb
xenconfig: fix conversion of <driver> to backendtype

When converting domXML to xen xl.cfg, backendtype should
not be emitted if <driver> is not specified. Moreover,
<driver name='file'/> should be converted to backendtype
qdisk, similar to handling of <driver> in libxlMakeDisk()
in libxl_conf.c.

Prior to this change, connectDomainXMLToNative would
produce incorrect xl.cfg when the input domXML contained
<driver name='file'/>

domXML:

  <disk type="file" device="disk">
    <driver name="file"/>
    <source file="/image/file/path"/>
    <target dev="xvda" bus="xen"/>
  </disk>

virsh domxml-to-native xen-xl domXML

disk = [ "format=raw,vdev=xvda,access=rw,backendtype=target=/image/file/path" ]

xl create xl.cfg
config parsing error in disk specification: unknown value
for backendtype: near `target=/image/file/path' in
`format=raw,vdev=xvda,access=rw,backendtype=target=/image/file/path'
src/xenconfig/xen_xl.c