]> xenbits.xensource.com Git - people/royger/linux-2.6.18-xen.git/commit
xenbus: do not hold transaction_mutex when returning to userspace xen-3.4.2
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 4 Nov 2009 18:13:32 +0000 (18:13 +0000)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 4 Nov 2009 18:13:32 +0000 (18:13 +0000)
commite30493b03bc28030af2d0d605abcc04e77b4abe7
tree08d0aab7c88cd74049faf988fdc2b7f4610126bb
parent968b07cb167c93e6fe1e5d4672155338dbcca7bb
xenbus: do not hold transaction_mutex when returning to userspace

  ================================================
  [ BUG: lock held when returning to user space! ]
  ------------------------------------------------
  xenstore-list/3522 is leaving the kernel with locks still held!
  1 lock held by xenstore-list/3522:
   #0:  (&xs_state.transaction_mutex){......}, at: [<c026dc6f>]
   xenbus_dev_request_and_reply+0x8f/0xa0

The canonical fix for this type of issue appears to be to maintain a
count manually rather than using an rwsem so do that here.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
drivers/xen/xenbus/xenbus_xs.c