]> xenbits.xensource.com Git - xen.git/commit
x86/xsave: remove xfeat_mask checking from validate_xstate()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 3 Jun 2014 10:00:53 +0000 (12:00 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 3 Jun 2014 10:00:53 +0000 (12:00 +0200)
commite2e45c562889be2ae5977bf08b065c24591b07fc
tree3656bc7463b013d82cea3556b34bb3f5bfac6e41
parentb5b60656bf6f36e2e8e0798085cfe0697eaac926
x86/xsave: remove xfeat_mask checking from validate_xstate()

validate_xsave() is called codepaths which load new vcpu xsave state from
XEN_DOMCTL_{setvcpuextstate,sethvmcontext}, usually as part of migration.  In
both cases, this is the xfeature_mask of the saving Xen rather than the
restoring Xen.

Given that the xsave state itself is checked for consistency and validity on
the current cpu, checking whether it was valid for the cpu before migration is
not interesting (or indeed relevant, as the error can't be distinguished from
the other validity checking).

This change removes the need to pass the saving Xen's xfeature_mask,
simplifying the toolstack code and migration stream format in this area.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/domctl.c
xen/arch/x86/hvm/hvm.c
xen/arch/x86/xstate.c
xen/include/asm-x86/xstate.h
xen/include/public/arch-x86/hvm/save.h
xen/include/public/domctl.h