]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Always check nodeset provided to numatune
authorAndrea Bolognani <abologna@redhat.com>
Tue, 3 Jan 2023 17:46:05 +0000 (18:46 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 9 Jan 2023 10:09:31 +0000 (11:09 +0100)
commite152f0718f70be62fc8773ffeadde29456218680
treeddc6949bf334832d95af8afab4e3862a6cc07efc
parent6fabd215468fe31da4704029a1df59be3bc86d24
qemu: Always check nodeset provided to numatune

Up until commit 629282d88454, using mode=restrictive caused
virNumaSetupMemoryPolicy() to be called from qemuProcessHook(),
and that in turn resulted in virNumaNodesetIsAvailable() being
called and the nodeset being validated.

After that change, the only validation for the nodeset is the one
happening in qemuBuildMemoryBackendProps(), which is skipped when
using mode=restrictive.

Make sure virNumaNodesetIsAvailable() is called whenever a
nodeset has been provided by the user, regardless of the mode.

https://bugzilla.redhat.com/show_bug.cgi?id=2156289

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_64-latest.args [deleted file]
tests/qemuxml2argvdata/numatune-memnode-unavailable-restrictive.x86_64-latest.err [new file with mode: 0644]
tests/qemuxml2argvtest.c