]> xenbits.xensource.com Git - qemu-xen.git/commit
i386: hvf: Reset IRQ inhibition after moving RIP
authorRoman Bolshakov <r.bolshakov@yadro.com>
Sat, 28 Mar 2020 17:44:12 +0000 (20:44 +0300)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 2 Apr 2020 18:55:45 +0000 (14:55 -0400)
commitddd31732a7379e056749836ff37ff57718083ddb
treefa61df836309f26873213a01352725aad1798c68
parent622e99c5cfcb43d89dc39ed780ab43f48bf748c6
i386: hvf: Reset IRQ inhibition after moving RIP

The sequence of instructions exposes an issue:
  sti
  hlt

Interrupts cannot be delivered to hvf after hlt instruction cpu because
HF_INHIBIT_IRQ_MASK is set just before hlt is handled and never reset
after moving instruction pointer beyond hlt.

So, after hvf_vcpu_exec() returns, CPU thread gets locked up forever in
qemu_wait_io_event() (cpu_thread_is_idle() evaluates inhibition
flag and considers the CPU idle if the flag is set).

Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-Id: <20200328174411.51491-1-r.bolshakov@yadro.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
target/i386/hvf/vmx.h