]> xenbits.xensource.com Git - libvirt.git/commit
storage: fix scsi detach regression with cgroup ACLs
authorEric Blake <eblake@redhat.com>
Tue, 27 Nov 2012 13:55:00 +0000 (06:55 -0700)
committerEric Blake <eblake@redhat.com>
Fri, 30 Nov 2012 15:26:34 +0000 (08:26 -0700)
commitddd103d3426d31c4b27940b60e21247a2cbe1868
tree023102243c9d4800c9bd62fbee9002ff605fe8ac
parent4f9af0857c1547d19610e5c59efe45a8d847b67f
storage: fix scsi detach regression with cgroup ACLs

https://bugzilla.redhat.com/show_bug.cgi?id=876828

Commit 38c4a9cc introduced a regression in hot unplugging of disks
from qemu, where cgroup device ACLs were no longer being revoked
(thankfully not a security hole: cgroup ACLs only prevent open()
of the disk; so reverting the ACL prevents future abuse but doesn't
stop abuse from an fd that was already opened before the ACL change).

Commit 1b2ebf95 overlooked that there were two spots affected.

* src/qemu/qemu_hotplug.c (qemuDomainDetachDiskDevice):
Transfer backing chain before deletion.
* src/qemu/qemu_driver.c (qemuDomainDetachDeviceDiskLive): Fix
spacing (partly to ensure a different-looking patch).
src/qemu/qemu_driver.c
src/qemu/qemu_hotplug.c