]> xenbits.xensource.com Git - qemu-xen.git/commit
aio-posix: disable fdmon-io_uring when GSource is used
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 11 May 2020 18:36:30 +0000 (19:36 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 25 Aug 2020 19:30:13 +0000 (14:30 -0500)
commitdcc935873b688a789744ec0a2d0d1b3570d18a6c
treee948974aeb755c855a48a4e8b45c051676c0ba30
parent5145f2471caa4ef58e200e151f736e633a5fb1ac
aio-posix: disable fdmon-io_uring when GSource is used

The glib event loop does not call fdmon_io_uring_wait() so fd handlers
waiting to be submitted build up in the list. There is no benefit is
using io_uring when the glib GSource is being used, so disable it
instead of implementing a more complex fix.

This fixes a memory leak where AioHandlers would build up and increasing
amounts of CPU time were spent iterating them in aio_pending(). The
symptom is that guests become slow when QEMU is built with io_uring
support.

Buglink: https://bugs.launchpad.net/qemu/+bug/1877716
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf ("aio-posix: add io_uring fd monitoring implementation")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Message-id: 20200511183630.279750-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit ba607ca8bff4d2c2062902f8355657c865ac7c29)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
include/block/aio.h
util/aio-posix.c
util/aio-win32.c
util/async.c