]> xenbits.xensource.com Git - libvirt.git/commit
domain_conf: Remove zPCI validation from formatter
authorMichal Privoznik <mprivozn@redhat.com>
Sat, 27 Jun 2020 07:09:39 +0000 (09:09 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 29 Jun 2020 11:44:00 +0000 (13:44 +0200)
commitdb4b24b6926a110b09e43a69f1ce489f03f6d44f
tree7b2c698a4793126baaf3c7aa737079313dd492a3
parent90c9b90aee03fbde20a2bf8118e94fa73145e757
domain_conf: Remove zPCI validation from formatter

In 076591009ad a validation code was added to
virDomainDeviceInfoFormat() which reports an error if zPCI
address entered in was incomplete. But, there are two problems
with this approach.

The first problem is the placement of the code - it doesn't
belong into XML formatter rather than XML validator.

The second one is that at the point of formatting XML the post
parse callback has run and thus filled in required info.
Therefore this check can never do something useful and instead of
moving it into validator, it's removed completely.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/conf/domain_conf.c