]> xenbits.xensource.com Git - libvirt.git/commit
qemu: avoid launching non-x86 guests with 'pvspinlock' setting
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Tue, 24 Mar 2020 17:33:22 +0000 (14:33 -0300)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 25 Mar 2020 13:55:14 +0000 (14:55 +0100)
commitda7485c54eb2bf5b1635e67ba2ae4b5323d97a88
treeae6ba70b1f3ce045172822b642a4d7f9c90b1bad
parentdbda73ff27cf185fb5db498cc4db281b2d76778d
qemu: avoid launching non-x86 guests with 'pvspinlock' setting

The 'pvspinlock' feature is x86 only. The "<pvspinlock/>" declaration
will always have a value 'on' or 'off', and both will break QEMU when
launching non-x86 guests. This is the error message for
"<pvspinlock state='on'/>" when running a ppc64 guest:

qemu-kvm: Expected key=value format, found +kvm_pv_unhalt

A similar error message is thrown for "<pvspinlock state='off'/>".

This patch prevents non-x86 guests from launching with any
pvspinlock setting with a more informative error message:

error: unsupported configuration: The 'pvspinlock' feature is not
supported for architecture 'ppc64' or machine type 'pseries'

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_domain.c