]> xenbits.xensource.com Git - libvirt.git/commit
Fix hang in qemudDomainCoreDump.
authorChris Lalancette <clalance@redhat.com>
Wed, 10 Mar 2010 21:50:13 +0000 (16:50 -0500)
committerChris Lalancette <clalance@redhat.com>
Thu, 11 Mar 2010 17:45:05 +0000 (12:45 -0500)
commitd376b7d63ec1ef24ba4c812d58b9a414ddb561f8
treefeff4b5c9c3afae5d7a81268ceb87f419de4c707
parent2c555d87b0041e0d1ec4742386d2161d1b2f0600
Fix hang in qemudDomainCoreDump.

Currently if you dump the core of a qemu guest with
qemudDomainCoreDump, subsequent commands will hang
up libvirtd.  This is because qemudDomainCoreDump
uses qemuDomainWaitForMigrationComplete, which expects
the qemuDriverLock to be held when it's called.  This
patch does the simple thing and moves the qemuDriveUnlock
to the end of the qemudDomainCoreDump so that the driver
lock is held for the entirety of the call (as it is done
in qemudDomainSave).  We will probably want to make the
lock more fine-grained than that in the future, but
we can fix both qemudDomainCoreDump and qemudDomainSave
at the same time.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
src/qemu/qemu_driver.c