]> xenbits.xensource.com Git - libvirt.git/commit
storage: Fix volume cloning for logical volume.
authorAtsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Thu, 4 Apr 2013 05:15:06 +0000 (14:15 +0900)
committerJán Tomko <jtomko@redhat.com>
Thu, 4 Apr 2013 08:52:07 +0000 (10:52 +0200)
commitd369e50825b88251d13a489efa2a58919b18a2c2
treee500c785a244160f37c3bbddde631c8616c37098
parentea151935bb5cfacc0290f60960f8d515ca52ab29
storage: Fix volume cloning for logical volume.

When creating a logical volume with virStorageVolCreateXMLFrom,
"qemu-img convert" is called internally if clonevol is a file volume.
Then, vol->target.format is used as output_fmt parameter but the
target.format of logical volumes is always 0 because logical volumes
haven't the volume format type element.

Fortunately, 0 was treated as RAW file format before commit f772b3d9,
so there was no problem. But now, 0 is treated as the type of none,
qemu-img fails with "Unknown file format 'none'".

This patch fixes this issue by treating output block devices as RAW
file format like for input block devices.

Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
src/storage/storage_backend.c