]> xenbits.xensource.com Git - libvirt.git/commit
network: a different way of supporting firewalld zone for mode='open' networks
authorLaine Stump <laine@redhat.com>
Fri, 4 Oct 2024 22:14:36 +0000 (18:14 -0400)
committerLaine Stump <laine@redhat.com>
Wed, 9 Oct 2024 19:54:08 +0000 (15:54 -0400)
commitcb4e38d4b1e947d0718232a59f964f35ad156c74
treeeef39028f9a1414dfcc69f92c662aa4a0c1f4a32
parentd552d810b97d478675eac830164349d8a1a35e63
network: a different way of supporting firewalld zone for mode='open' networks

Now that networkAddFirewallRules and networkRemoveFirewallRules() are
being called for mode='open' networks, we just need to move the code
that sets the zone outside of the if (mode != ...OPEN) clause, so that
it's done for all forward modes, with the exception of setting the
implied 'libvirt*' zones, which are set when no zone is specified for
all forward modes *except* 'open'.

This was previously done in commit v10.7.0-76-g1a72b83d56, but in a
manner that caused the zone to be unset whenever firewalld reloaded
its rules. That patch was reverted, and this new better patch takes
its place.

Replaces: 1a72b83d566df952033529001b0f88a66d7f4393
Resolves: https://issues.redhat.com/browse/RHEL-61576
Re-Resolves: https://gitlab.com/libvirt/libvirt/-/issues/215
Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/network/bridge_driver_linux.c