]> xenbits.xensource.com Git - qemu-xen.git/commit
vhost-scsi: prevent using uninitialized vqs
authoryuchenlin <yuchenlin@synology.com>
Fri, 12 Oct 2018 09:07:52 +0000 (17:07 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 27 Mar 2019 06:31:28 +0000 (01:31 -0500)
commitca1b4263d953a7f9b146d14a946ac7aff25d280d
tree4f8dc911f209a4ca1da58334ede876232b3c87a6
parentef862b9e8e99161555147b856c8b2be205dc23f9
vhost-scsi: prevent using uninitialized vqs

There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
but seabios will only set the physical address for the 3rd one (cmd).
Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
will be 0 for ctrl and event vq.

In this case, ctrl and event vq are not initialized.
vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
such that vhost_verify_ring_part_mapping returns ENOMEM.

When encountered this problem, we got the following logs:

    qemu-system-x86_64: Unable to map available ring for ring 0
    qemu-system-x86_64: Verify ring failure on region 0

Signed-off-by: Forrest Liu <forrestl@synology.com>
Signed-off-by: yuchenlin <yuchenlin@synology.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit e6cc11d64fc998c11a4dfcde8fda3fc33a74d844)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/scsi/vhost-scsi.c