]> xenbits.xensource.com Git - qemu-upstream-4.2-testing.git/commit
virtio-blk: refuse SG_IO requests with scsi=off
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 23 Dec 2011 14:39:03 +0000 (15:39 +0100)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 4 Mar 2015 15:57:46 +0000 (15:57 +0000)
commitc84338fd1b3c526b7e4ad9b5f5c54e7121315b94
tree2a9b9a1839cc03f34fae2121e4cc5bf0b1d5b252
parent6d17c397dfadb29e641d5da1eb3381d240decedc
virtio-blk: refuse SG_IO requests with scsi=off

QEMU does have a "scsi" option (to be used like -device
virtio-blk-pci,drive=foo,scsi=off).  However, it only
masks the feature bit, and does not reject the command
if a malicious guest disregards the feature bits and
issues a request.

Without this patch, using scsi=off does not protect you
from CVE-2011-4127.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/virtio-blk.c