]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commit
Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap"
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Mon, 22 Jun 2015 13:00:42 +0000 (13:00 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Wed, 24 Jun 2015 13:32:37 +0000 (13:32 +0000)
commitc4a962ec0c61aa9b860a3635c8424472e6c2cc2c
tree779fd60e1a06c01ddeea7d2fe6dc32d5f08cc1d8
parentf0e7abf7120d997c28a0729fe71e0db7194c9199
Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap"

This reverts commit c1d322e6048796296555dd36fdd102d7fa2f50bf.

The original commit fixes a bug when assigning a large number of
devices which require option roms to a guest.  (One known
configuration that needs extra memory is having more than 4 emulated
NICs assigned.  Three or fewer NICs seems to work without this
functionality.)

However, by unilaterally increasing maxmem, it introduces two
problems.

First, now libxl's calculation of the required maxmem during migration
is broken -- any guest which exercised this functionality will fail on
migration.  (Guests which have the default number of devices are not
affected.)

Secondly, it makes it impossible for a higher-level toolstack or
administer to predict how much memory a VM will actually use, making
it much more difficult to effectively use all of the memory on a
machine.

Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
xen-hvm.c