]> xenbits.xensource.com Git - qemu-xen-unstable.git/commit
cirrus: fix oob access issue (CVE-2017-2615)
authorLi Qiang <liqiang6-s@360.cn>
Mon, 13 Feb 2017 15:22:15 +0000 (15:22 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Wed, 22 Feb 2017 16:25:15 +0000 (16:25 +0000)
commitc4018bc4d638918b3f8fb49dd3b379abb5658ee1
tree7693e254ba04f32112c3b5786f0dea89b17a0ce5
parentb669e922b37b8957248798a5eb7aa96a666cd3fe
cirrus: fix oob access issue (CVE-2017-2615)

When doing bitblt copy in backward mode, we should minus the
blt width first just like the adding in the forward mode. This
can avoid the oob access of the front of vga's vram.

This is XSA-208.

upstream-commit-id: 62d4c6bd5263bb8413a06c80144fc678df6dfb64

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
{ kraxel: with backward blits (negative pitch) addr is the topmost
          address, so check it as-is against vram size ]

[ This is CVE-2017-2615 / XSA-208  - Ian Jackson ]

Cc: qemu-stable@nongnu.org
Cc: P J P <ppandit@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: d3532a0db02296e687711b8cdc7791924efccea0 (CVE-2014-8106)
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1485938101-26602-1-git-send-email-kraxel@redhat.com
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
hw/cirrus_vga.c