]> xenbits.xensource.com Git - libvirt.git/commit
libxl: add support for specifying clock offset and adjustment
authorJim Fehlig <jfehlig@suse.com>
Tue, 20 Feb 2018 23:51:27 +0000 (16:51 -0700)
committerJim Fehlig <jfehlig@suse.com>
Wed, 21 Feb 2018 19:28:49 +0000 (12:28 -0700)
commitc391e07eb08d713474ae8998cfd859e1827a4b2d
tree59c5516af07c0d2570031d3f3393d09811503730
parent04bcc4d9ab848ec7aaa7c9f5fe7a64006b7a0d52
libxl: add support for specifying clock offset and adjustment

libxl supports setting the domain real time clock to local time or
UTC via the localtime field of libxl_domain_build_info. Adjustment
of the clock is also supported via the rtc_timeoffset field. The
libvirt libxl driver has never supported these settings, instead
relying on libxl's default of a UTC real time clock with adjustment
set to 0.

There is at least one user that would like the ability to change
the defaults

https://www.redhat.com/archives/libvirt-users/2018-February/msg00059.html

Add support for specifying a local time clock and for specifying an
adjustment for both local time and UTC clocks. Add a test case to
verify the XML to libxl_domain_config conversion.

Local time clock and clock adjustment is already supported by the
XML <-> xl.cfg converter. What is missing is an explicit test for
the conversion. There are plenty of existing tests that all use UTC
with 0 adjustment. Hijack test-fullvirt-tsc-timer to test a local
time clock with 1 hour adjustment.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/libxl/libxl_conf.c
tests/libxlxml2domconfigdata/variable-clock-hvm.json [new file with mode: 0644]
tests/libxlxml2domconfigdata/variable-clock-hvm.xml [new file with mode: 0644]
tests/libxlxml2domconfigtest.c
tests/xlconfigdata/test-fullvirt-tsc-timer.cfg
tests/xlconfigdata/test-fullvirt-tsc-timer.xml