]> xenbits.xensource.com Git - people/andrewcoop/seabios.git/commit
SeaVGABios/cbvga: Fix bpp for coreboot framebuffer
authorMatt DeVillier <matt.devillier@puri.sm>
Tue, 11 Sep 2018 21:54:53 +0000 (16:54 -0500)
committerKevin O'Connor <kevin@koconnor.net>
Tue, 18 Sep 2018 17:35:30 +0000 (13:35 -0400)
commitbf8e4f902c3608f9e76bba3710812e51560a2ccc
tree10a1303fed12892545da111007daf1a35ff8123a
parentbcd82420a32d1fe597a88e601959e9d5fe4c70df
SeaVGABios/cbvga: Fix bpp for coreboot framebuffer

Commit 4b42cc4 [SeaVGABios/cbvga: Advertise correct pixel format] neglected
to wrap the cbfb mask size components in GET_FARVAR(), which resulted in a
bogus value for bpp, breaking output on most/all devices.  Fix this by
adding GET_FARVAR() as appropriate.

Additionally, some newer ChromeOS devices still fail even with this fix,
so fall back to using the coreboot reported bit depth if the calculated
valid is invalid.

TEST: build/boot a variety of devices (google/[reef,eve], purism/librem_skl)
using coreboot framebuffer init, verify SeaBIOS boot menu prompt visible.

Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
vgasrc/cbvga.c