]> xenbits.xensource.com Git - qemu-xen.git/commit
migration: Revert mapped-ram multifd support to fd: URI
authorFabiano Rosas <farosas@suse.de>
Tue, 19 Mar 2024 21:09:41 +0000 (18:09 -0300)
committerPeter Xu <peterx@redhat.com>
Fri, 22 Mar 2024 16:12:08 +0000 (12:12 -0400)
commitbd4480b0d02ee760b51aa82cc0915174753716ee
treeb846ac27ff222145595e7cb6534473ed659a9bc1
parent853546f8128476eefb701d4a55b2781bb3a46faa
migration: Revert mapped-ram multifd support to fd: URI

This reverts commit decdc76772c453ff1444612e910caa0d45cd8eac in full
and also the relevant migration-tests from
7a09f092834641b7a793d50a3a261073bbb404a6.

After the addition of the new QAPI-based migration address API in 8.2
we've been converting an "fd:" URI into a SocketAddress, missing the
fact that the "fd:" syntax could also be used for a plain file instead
of a socket. This is a problem because the SocketAddress is part of
the API, so we're effectively asking users to create a "socket"
channel to pass in a plain file.

The easiest way to fix this situation is to deprecate the usage of
both SocketAddress and "fd:" when used with a plain file for
migration. Since this has been possible since 8.2, we can wait until
9.1 to deprecate it.

For 9.0, however, we should avoid adding further support to migration
to a plain file using the old "fd:" syntax or the new SocketAddress
API, and instead require the usage of either the old-style "file:" URI
or the FileMigrationArgs::filename field of the new API with the
"/dev/fdset/NN" syntax, both of which are already supported.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240319210941.1907-1-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/fd.c
migration/fd.h
migration/file.c
migration/migration.c
migration/multifd.c
tests/qtest/migration-test.c