]> xenbits.xensource.com Git - libvirt.git/commit
util: consolidate on one free callback for hash data
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 21 Nov 2019 19:27:58 +0000 (19:27 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 22 Nov 2019 14:21:28 +0000 (14:21 +0000)
commitbc7e72914a07db9050eab2df8341262c46035717
treeafa6e0bedd2f7dc35f69cc7e8ed8e596cf6c1d71
parentfeef23e130d4b02377323ae2c20376ec990182a1
util: consolidate on one free callback for hash data

This previous commit introduced a simpler free callback for
hash data with only 1 arg, the value to free:

  commit 49288fac965f0ee23db45d83ae4ef3a9a71dafd0
  Author: Peter Krempa <pkrempa@redhat.com>
  Date:   Wed Oct 9 15:26:37 2019 +0200

    util: hash: Add possibility to use simpler data free function in virHash

It missed two functions in the hash table code which need
to call the alternate data free function, virHashRemoveEntry
and virHashRemoveSet.

After the previous patch though, there is no code that
makes functional use of the 2nd key arg in the data
free function. There is merely one log message that can
be dropped.

We can thus purge the current virHashDataFree callback
entirely, and rename virHashDataFreeSimple to replace
it.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
27 files changed:
src/conf/domain_addr.c
src/conf/nwfilter_params.c
src/conf/virchrdev.c
src/conf/virdomainmomentobjlist.c
src/conf/virnetworkobj.c
src/libxl/libxl_logger.c
src/locking/lock_daemon.c
src/nwfilter/nwfilter_dhcpsnoop.c
src/nwfilter/nwfilter_learnipaddr.c
src/qemu/qemu_block.c
src/qemu/qemu_conf.c
src/qemu/qemu_conf.h
src/qemu/qemu_domain.c
src/qemu/qemu_migration.c
src/qemu/qemu_monitor.c
src/qemu/qemu_monitor.h
src/qemu/qemu_monitor_json.c
src/util/vircgroup.c
src/util/virhash.c
src/util/virhash.h
src/util/virjson.c
src/util/virjson.h
src/util/virkeyfile.c
src/util/virlockspace.c
src/util/virobject.c
src/util/virobject.h
src/util/virsystemd.c