]> xenbits.xensource.com Git - xen.git/commit
x86/spec-ctrl: Improve all SPEC_CTRL_{ENTER,EXIT}_* comments
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 30 Aug 2023 19:11:50 +0000 (20:11 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 19 Sep 2023 18:36:49 +0000 (19:36 +0100)
commitba023e93d0b1e60b80251bf080bab694efb9f8e3
treec7f85decfa1c38ed38da0e22255f9317fc81cdb5
parent3952c73bdbd05f0e666986fce633a591237b3c88
x86/spec-ctrl: Improve all SPEC_CTRL_{ENTER,EXIT}_* comments

... to better explain how they're used.

Doing so highlights that SPEC_CTRL_EXIT_TO_XEN is missing a VERW flush for the
corner case when e.g. an NMI hits late in an exit-to-guest path.

Leave a TODO, which will be addressed in subsequent patches which arrange for
VERW flushing to be safe within SPEC_CTRL_EXIT_TO_XEN.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
(cherry picked from commit 45f00557350dc7d0756551069803fc49c29184ca)
xen/arch/x86/include/asm/spec_ctrl_asm.h