]> xenbits.xensource.com Git - libvirt.git/commit
conf: replace virHostdevIsVFIODevice with virHostdevIsPCIDevice
authorLaine Stump <laine@redhat.com>
Fri, 5 Jan 2024 01:12:51 +0000 (20:12 -0500)
committerLaine Stump <laine@redhat.com>
Mon, 8 Jan 2024 04:58:44 +0000 (23:58 -0500)
commitb9a1e7c4364b7700537d5e2dbdd65cf808e01520
tree28f6789bb5965010cd88778013e47a60b7c826cc
parentbb1acb9ca23a519258f688d71d69029c8a4d7665
conf: replace virHostdevIsVFIODevice with virHostdevIsPCIDevice

virHostdevIsVFIODevice() and virDomainDefHasVFIOHostdev() are only ever
called from the QEMU driver, and in the case of the QEMU driver, any
PCI hostdev by definition uses VFIO, so really all these callers only
need to know if the device is a PCI hostdev.

(It turned out that the less specific virHostdevIsPCIDevice() already
existed in hypervisor/virhostdev.c, so I had to remove one of them;
since conf is a lower level directory than hypervisor, and the
function is called from conf, keeping the copy in hypervisor would
have required moving its caller (virDomainDefHasPCIHostdev()) into
hypervisor as well, so I just removed the copy in hypervisor.)

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/conf/domain_conf.c
src/conf/domain_conf.h
src/hypervisor/virhostdev.c
src/hypervisor/virhostdev.h
src/libvirt_private.syms
src/qemu/qemu_domain.c
src/qemu/qemu_hostdev.c
src/qemu/qemu_hotplug.c