]> xenbits.xensource.com Git - qemu-xen-traditional.git/commit
xenfb: avoid reading twice the same fields from the shared page
authorStefano Stabellini <stefano.stabellini@eu.citrix.com>
Fri, 20 Nov 2015 15:37:08 +0000 (10:37 -0500)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 18 Dec 2015 14:55:13 +0000 (14:55 +0000)
commitb8bcb5e754881c4e6bee871a789c178fb5b00fcb
treee2264a6f84b1ee991cc11516dc987b917219e058
parent9fad9ed285835caef64bb8dab352e287ad8538c2
xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xenfb.c