]> xenbits.xensource.com Git - qemu-xen.git/commit
s390x/ccw: make sure all ccw devices are properly reset
authorCornelia Huck <cohuck@redhat.com>
Mon, 7 May 2018 13:27:57 +0000 (15:27 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 21 Jun 2018 01:45:04 +0000 (20:45 -0500)
commitb68ef5920a110f394350763950fd85f3d467ebfa
tree5f0f2fad751d3003e1eaf09a65d9e27565730330
parentb2ca60262720c6e12ff776b62bd8880f4edd9c7d
s390x/ccw: make sure all ccw devices are properly reset

Thomas reported that the subchannel for a  3270 device that ended up
in a broken state (status pending even though not enabled) did not
get out of that state even after a reboot (which involves a subsytem
reset). The reason for this is that the 3270 device did not define
a reset handler.

Let's fix this by introducing a base reset handler (set up for all
ccw devices) that resets the subchannel and have virtio-ccw call
its virtio-specific reset procedure in addition to that.

CC: qemu-stable@nongnu.org
Reported-by: Thomas Huth <thuth@redhat.com>
Suggested-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
(cherry picked from commit 838fb84f83c84f00d15b1bede5e080b495644458)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/s390x/ccw-device.c
hw/s390x/virtio-ccw.c
hw/s390x/virtio-ccw.h