]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commit
blockjob: don't remove older-style mirror XML
authorEric Blake <eblake@redhat.com>
Mon, 16 Jun 2014 19:34:36 +0000 (13:34 -0600)
committerEric Blake <eblake@redhat.com>
Mon, 16 Jun 2014 19:48:00 +0000 (13:48 -0600)
commitb50e1049234473b36e798b8ebd842cb84ef023dc
treeb7eac13d39c8b384f4fcd7b5466e7e4a2f602e4f
parentcfe087a211a11a554c396b2b94505c0ae0585b4d
blockjob: don't remove older-style mirror XML

Commit 7c6fc39 introduced a regression in the XML produced for older
clients.  The argument at the time was that clients shouldn't be
depending on output-only data for something that is only going to
be triggered for a transient guest; but John Ferlan reported that
the automated testsuite was such a client.  It's better to be safe
than sorry by guaranteeing back-compat cruft.  Note that later
patches will be using <mirror> for active block commit, but there
we don't have to worry about back-compat.

* src/conf/domain_conf.c (virDomainDiskDefFormat): Restore old
style output when necessary.
* docs/schemas/domaincommon.rng: Validate back-compat style.
* docs/formatdomain.html.in: Update the documentation.
* tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror-old.xml:
Update tests.
* tests/qemuxml2argvdata/qemuxml2argv-disk-mirror.xml: Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
docs/formatdomain.html.in
docs/schemas/domaincommon.rng
src/conf/domain_conf.c
tests/qemuxml2argvdata/qemuxml2argv-disk-mirror.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror-old.xml