]> xenbits.xensource.com Git - libvirt.git/commit
qemu: Don't try to start NBD server twice
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Oct 2020 08:49:35 +0000 (09:49 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Oct 2020 12:08:47 +0000 (13:08 +0100)
commitb4682b7333c0a27d5f0cb94fec24b0b8b26586d5
tree6d5ff024e62c2170b39fcb4c31a2a3589c0e0d88
parentf971539e4dc6e7f643032cd8089997f85e4fbab0
qemu: Don't try to start NBD server twice

In one of recent patches the way that we start NBD server for
incoming migration was reworked (v6.8.0-rc1~298). A new boolean
was introduced that tracks whether the NBD server was started so
that we don't start it twice nor record in the port in the port
allocator twice. Well, this idea is good, but in the
implementation the boolean is never set, so we are reserving the
port twice and would be starting the NBD server twice too if it
wasn't for port reservation fail.

Fixes: e74d627bb3bc2684cbe3edc1e2f7cc745b4e1ff3
Reported-by: Vjaceslavs Klimovs <vklimovs@gmail.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_migration.c